Clean duplicate adm0s #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@t-downing could you take a look at the outputs in the I'll rerun against all dates on @isatotun tagged you for awareness on changes in this pipeline. |
Yes the outputs look plausible to me! I only checked |
isatotun
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #16. As noted in the docstring, this script is really intended to be a temporary workaround so I haven't invested a ton of time into making it fully productionalized. I'm hoping this will get fixed in Fieldmaps directly, and we'll also have a better way to eventually query the Fieldmaps data.
Once merged, I'll rerun all historical stats for
NGA,TCD, andBDI.