Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check coverage #33

Merged
merged 7 commits into from
Dec 20, 2024
Merged

Check coverage #33

merged 7 commits into from
Dec 20, 2024

Conversation

hannahker
Copy link
Collaborator

@hannahker hannahker commented Dec 11, 2024

Addresses #26. To accomplish this, I've adjusted the handling of dates to be based on an input list, rather than a range defined by start and end dates. I think this is cleaner overall. Since the config is a bit more complex, I've also added much more detailed logging to the beginning of the pipeline run:

Screenshot 2024-12-11 at 3 19 46 PM

@hannahker hannahker requested a review from isatotun December 12, 2024 01:03
Copy link
Contributor

@isatotun isatotun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have gone over the changes in the call and it all seems good to me. Thanks for this!

@hannahker hannahker merged commit ac468e5 into main Dec 20, 2024
1 check passed
@hannahker hannahker deleted the check-coverage branch December 20, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants