Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #23 and #19.
The
polygon
table onprod
is missing all pcodes for NGA and TCD. This was fixed when #16 was merged. However these changes and the integration of Floodscan (see #25) caused issues where 'PRI', 'FJI', 'UZB', 'KIR', and 'BRA' were dropped from thepolygon
table. This is because of an error due to the fact that these iso3s all slightly overlap with the edges of the floodscan raster so that they aren't caught with this condition. This results in the iso3 being dropped for all datasets.This PR fixes the issue with a more complete check against the coverage for a given dataset.
This diff overrepresents the changes all because of a change in indentation. Basically I've just added the following flag: