Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create polygon metadata table #8

Merged
merged 9 commits into from
Nov 1, 2024
Merged

Create polygon metadata table #8

merged 9 commits into from
Nov 1, 2024

Conversation

hannahker
Copy link
Collaborator

@hannahker hannahker commented Oct 23, 2024

Computing basic metadata about each polygon for which we're calculating summary stats. See this Confluence page for a description of each field.

To do:

  • Add Bool standard column to indicate if a polygon is a "standard" admin bound. Would be all True so far.

@hannahker hannahker added the enhancement New feature or request label Oct 24, 2024
@hannahker hannahker requested a review from isatotun November 1, 2024 13:32
Copy link
Contributor

@isatotun isatotun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have enough background yet for a more detailed review but I don't see anything absurd!

upsampled_resolution=UPSAMPLED_RESOLUTION,
sel_iso3s=None,
)
sys.exit(0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this sys.exit here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just because the program can terminate here after updating the metadata!

@hannahker hannahker merged commit a0aae08 into main Nov 1, 2024
1 check passed
@hannahker hannahker deleted the polygon-table branch November 1, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants