Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDX-10422 Update Page titles & descriptions to new structure #6527

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from

Conversation

aalecs
Copy link
Member

@aalecs aalecs commented Jan 31, 2025

No description provided.

aalecs added 12 commits January 27, 2025 16:19
   - refactor out the count endpoints (3 ajax calls per homepage render) in order to have the info in the description meta
   - other refactor to follow ideas from Lighthouse for SEO
   - change sufix for page titles to " | HDX"
  - extract selected filter titles
  - implement separated logic for featured filters
  - use two scenarios: with or withot filters; similar to ecomm sites
  - implement titles & descr also for the mobile version of the page
  - change regular and mobile page
  - implement single org page - mobile version, desktop and custom org
  - work on pages that extend the main org page: activity stream, members, etc
  - change regular and mobile page
  - implement single org page - mobile version, desktop and custom org
  - work on pages that extend the main org page: activity stream, members, etc
  - fix for spacing in title for non edited pages + refactor existing
  - event & dashboard pages
  - same for FAQ and all derived pages (terms, licenses, dev)
@coveralls
Copy link

Pull Request Test Coverage Report for Build #6040

Details

  • 15 of 16 (93.75%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 75.076%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ckanext-hdx_search/ckanext/hdx_search/controller_logic/search_logic.py 10 11 90.91%
Totals Coverage Status
Change from base Build #6038: 0.1%
Covered Lines: 12618
Relevant Lines: 16807

💛 - Coveralls

@aalecs aalecs requested a review from danmihaila January 31, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants