Feature/ecmwf seas download #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First version of how the ecmwf api can be used to download data.
Mainly a draft cause I was moving around the area functionalities. @turnerm I now left the
AreaFromStationsincds/area.py. But actually what I think it does is create a bounding box around a list of lon-lat coords. I haven't been working with it so didn't want to change it. But would it make sense to rename it toAreaFromListor so, and then add it toutils/area.py? In that case I don't think we need thecds/area.pyfile anymore as it would only contain one function.As always I still have to create tests, but to me that feels it makes more sense after the code has been finalized more.
Also, I am struggling quite a bit with where to define folder+file names. I imagine part of this could be solved when using classes, but not 100% how, so if you got tips on that, happy to hear!