Change response for pod with user in no class to 200

This fixes the issue where the webhook returns a 400 response in the case where the pods user doesn't belong to any class. This caused issues for deployments trying to start up pods but being unable to because of the error response from the webhook. Signed-off-by: Isaiah Stapleton <[email protected]>
OCP-on-NERC · Sep 19, 2024 · 3630af2 · 3630af2
1 parent 02b05c5
commit 3630af2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/container-images/assign-class-label/mutate.py b/container-images/assign-class-label/mutate.py
@@ -131,7 +131,7 @@ def mutate_pod() -> Response:
                         )
                     ).model_dump()
                 ),
-                400,
+                200,
                 {'content-type': 'application/json'},
             )
 

diff --git a/container-images/assign-class-label/tests/test_mutate.py b/container-images/assign-class-label/tests/test_mutate.py
@@ -71,7 +71,7 @@ def test_request_no_metadata(client):
         },
     )
 
-    assert res.status_code == 400
+    assert res.status_code == 200
     assert res.json == {
         'apiVersion': 'admission.k8s.io/v1',
         'kind': 'AdmissionReview',
@@ -172,7 +172,7 @@ def test_no_user(client):
         },
     )
 
-    assert res.status_code == 400
+    assert res.status_code == 200
     assert res.json == {
         'apiVersion': 'admission.k8s.io/v1',
         'kind': 'AdmissionReview',
@@ -195,7 +195,7 @@ def test_no_user(client):
         },
     )
 
-    assert res.status_code == 400
+    assert res.status_code == 200
     assert res.json == {
         'apiVersion': 'admission.k8s.io/v1',
         'kind': 'AdmissionReview',
@@ -229,7 +229,7 @@ def test_empty_group_members(client):
             },
         )
 
-        assert res.status_code == 400
+        assert res.status_code == 200
         assert res.json == {
             'apiVersion': 'admission.k8s.io/v1',
             'kind': 'AdmissionReview',