Update RHOAI_CLASS_GROUPS for f24 semester and add externalsecret #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanNiESh
reviewed
Oct 8, 2024
IsaiahStapleton
changed the title
IsaiahStapleton
force-pushed
the
assign-class-label
branch
2 times, most recently
from
4bd4b3c
to
bc2f01e
Compare
Signed-off-by: Isaiah Stapleton <[email protected]>
IsaiahStapleton
force-pushed
the
assign-class-label
branch
from
bc2f01e
to
f0f3ec6
Compare
larsks
requested changes
Oct 8, 2024
Comment on lines
12
to
16
| data: | ||
| - secretKey: webhook-cert | ||
| remoteRef: | ||
| key: nerc/nerc-ocp-prod/rhods-notebooks/webhook-cert | ||
| property: webhook-cert |
There was a problem hiding this comment.
While the secret path here is correct, there is no property webhook-cert in the vault secret. There are two properties (webhook.crt and webhook.key) and you probably want both. I think the way to do that is:
Suggested change
| data: | |
| - secretKey: webhook-cert | |
| remoteRef: | |
| key: nerc/nerc-ocp-prod/rhods-notebooks/webhook-cert | |
| property: webhook-cert | |
| data: | |
| - secretKey: webhook-cert | |
| dataFrom: | |
| - extract: | |
| key: nerc/nerc-ocp-prod/rhods-notebooks/webhook-cert |
Signed-off-by: Isaiah Stapleton <[email protected]>
Signed-off-by: Isaiah Stapleton <[email protected]>
IsaiahStapleton
force-pushed
the
assign-class-label
branch
from
f0f3ec6
to
756a496
Compare
IsaiahStapleton
changed the title
IsaiahStapleton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.