Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disable-aslr & seccomp-profile-installer apps #34

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

IsaiahStapleton
Copy link
Contributor

@IsaiahStapleton IsaiahStapleton commented Jan 19, 2024

These apps deploy the necessary resources for allowing the personality and ptrace system calls in the rhods-notebooks namespace. This allows us to get the functionality the CS 210 and EC 440 courses need from GDB.

@IsaiahStapleton IsaiahStapleton requested review from larsks and computate and removed request for computate January 19, 2024 17:18
@computate
Copy link
Member

@IsaiahStapleton can you please add a description why this is going into NERC Prod?

@IsaiahStapleton
Copy link
Contributor Author

@computate I added a description to the PR that explains why its going into NERC prod, the README in this repo: https://github.com/IsaiahStapleton/disable-aslr-nerc also gives a more whole explanation of the solution

@computate
Copy link
Member

@IsaiahStapleton There is a sleep 5 in the watchsa.sh script. Should this be configurable in an Environment Variable in the Deployment in case of performance issues every 5 seconds?

@IsaiahStapleton
Copy link
Contributor Author

IsaiahStapleton commented Jan 19, 2024

@computate Possibly. The thing is that from the moment a students hits start server and the request for the instance to be created starts, the script needs to apply the scc to their service account that is created before the instance starts so that they are using the correct seccomp profile. That means the script needs to be run every few seconds so that it can catch the creation of the service account before the instance is launched. @larsks what do you think?

@larsks
Copy link
Member

larsks commented Jan 19, 2024

The _oc get sa -o name --watch command in that script is a blocking operation. The script is not looping every 5 seconds; that sleep 5 only comes into play if the --watch command exits. The sleep is to prevent overly rapid cycling, but in general we expect the script to be idling at the oc get --watch command.

@IsaiahStapleton IsaiahStapleton merged commit 836fe50 into OCP-on-NERC:main Jan 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants