Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ArgoCD Application for nerc-ocp-obs Observability cluster #36

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

computate
Copy link
Member

@computate computate commented Jan 22, 2024

This will manage the cluster-scope for the new Observability cluster.

fixes nerc-project/operations#309

Copy link
Contributor

@schwesig schwesig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR @computate. As we talked about earlier. Approved.

@schwesig
Copy link
Contributor

@schwesig

@schwesig schwesig added the enhancement New feature or request label Jan 22, 2024
Copy link
Member

@larsks larsks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a spelling error in the commit title and the PR title. s/Obsebrvability/Observability/

@computate computate changed the title Adding ArgoCD Application for nerc-ocp-obs Obsebrvability cluster Adding ArgoCD Application for nerc-ocp-obs Observability cluster Jan 22, 2024
This will manage the cluster-scope for the new Observability cluster.
@computate
Copy link
Member Author

Oops, should be fixed now @larsks , thanks!

@schwesig schwesig requested a review from larsks January 22, 2024 20:57
@computate computate merged commit c5bcf26 into OCP-on-NERC:main Jan 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attach observability cluster to argocd
4 participants