staging -> production #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1f8c0ec.
This reverts commit 5e9b059.
##JIRA Ticket [CC-2137 NZSL: move signbank to Poetry](https://ackama.atlassian.net/browse/CC-2137) ## Changes - `requirements.*` files removed - `pyproject.toml` and `poetry.lock` added - unpinned all dependencies - added `depends_on` and `healthcheck` to `docker-compose.yml` to avoid database race condition on local dev - exposed port `5432` on local dev - `0.0.0.0` added to `DEFAULT_ALLOWED_HOSTS`
Fix reversion that was preventing important functions working, eg. new gloss. ## JIRA Ticket [CC-2137 NZSL: move signbank to Poetry](https://ackama.atlassian.net/browse/CC-2137) ## Changes - `ugetttext` is back to being `gettext` ## Notes This was changed at some point in `django/utils/translation`, with effect the interim measure (required at one point during phased upgrades) of aliasing the two calls together stopped working
Micky Vale was still getting errors on UAT when she tried to create a new Gloss. This should hopefully fix this. ## JIRA Ticket [CC-2137 NZSL: move signbank to Poetry](https://ackama.atlassian.net/browse/CC-2137) ## Changes - `GlossVideo` method `rename_video()` uses `name` instead of `path` from `storage`, see Notes below ## Notes - A Stack Overflow that describes the `path` / `name` issue: https://stackoverflow.com/a/69135593
## Jira Ticket [CC-2137 NZSL: move signbank to Poetry](https://ackama.atlassian.net/browse/CC-2137) ## Changes - This restores the exact package versions from the original `requirements.txt`
Changing `docker-compose` to `docker compose`, as the former is no longer supported anywhere including Travis. Leaving OSV warnings as they will be addressed by other PRs soon enough.
jonholdsworth
requested review from
joshmcarthur,
jadedarko,
G-Rath and
nzlaura
|
Couple of OSVs that are probably worth addressing while we're waiting. |
While these should be patchable, currently we're in the process of trying to get another deployment out so for now lets just ignore them
This means that GitHub will be able to track deployments, and in turn we should start getting these properly logged in Mahi. As part of this, I've introduced a new `tests` job that handles running the test suite, and made it a requirement that both that job and the auditing job pass before a deployment will happen; I will handle formatting and security hardening in a follow up PR
|
Micky has approved this push. Please review. |
nzlaura
approved these changes
Feb 18, 2025
G-Rath
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements:
CC-2137 NZSL: move signbank to Poetry
Now that we have the databases sync'd between production and UAT, and the same for their S3 buckets, Micky Vale should be able to determine if UAT is functioning safely to her satisfaction.
If she does, and approves this push, this will change production over to using
poetry, along with some other fixes.