Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert DQD camelCase to upper-snake to match AresIndexer #35

Closed
wants to merge 1 commit into from

Conversation

alondhe
Copy link

@alondhe alondhe commented Apr 6, 2023

Fixes #30

xitology added a commit to TuftsCTSI/AresIndexer that referenced this pull request Apr 26, 2023
xitology added a commit to TuftsCTSI/AresIndexer that referenced this pull request Apr 26, 2023
xitology added a commit to TuftsCTSI/AresIndexer that referenced this pull request Apr 26, 2023
xitology added a commit to TuftsCTSI/AresIndexer that referenced this pull request Apr 26, 2023
xitology added a commit to TuftsCTSI/AresIndexer that referenced this pull request Apr 26, 2023
xitology added a commit to TuftsCTSI/AresIndexer that referenced this pull request Apr 26, 2023
xitology added a commit to TuftsCTSI/AresIndexer that referenced this pull request Apr 26, 2023
xitology added a commit to TuftsCTSI/AresIndexer that referenced this pull request Apr 26, 2023
@fdefalco
Copy link
Contributor

fdefalco commented Jun 9, 2023

The preferred approach will be to use the conversion function added to the DQD package to convert older files when AresIndexer and ARES are updated to expect the new camel-case. In the mean time DQD also has a function to convert back to the snake case.

https://ohdsi.github.io/DataQualityDashboard/reference/convertJsonResultsFileCase.html

@fdefalco fdefalco closed this Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AresIndexer::augmentConceptFiles fails with "! object 'CONCEPT_ID' not found"
2 participants