Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure all cohort manipulation functions work within observation periods #263

Open
edward-burn opened this issue Aug 27, 2024 · 1 comment
Assignees
Milestone

Comments

@edward-burn
Copy link
Collaborator

As well as #256, make sure that any other functions that collapse cohort entries respect observation periods. If one cohort entry is in one observation period and another is in a second observation period then we should not concatanate them as we will get a cohort entry that goes outside of observation.

We should use observation period id as a grouping variable.

@OHDSI OHDSI deleted a comment Aug 27, 2024
@edward-burn edward-burn added this to the cran v0.3 milestone Aug 28, 2024
@edward-burn
Copy link
Collaborator Author

functions to add tests to check this behaviour:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants