Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion around the Broadsea-Hades container repo #25

Open
ftrotter opened this issue Oct 23, 2023 · 1 comment
Open

Confusion around the Broadsea-Hades container repo #25

ftrotter opened this issue Oct 23, 2023 · 1 comment

Comments

@ftrotter
Copy link

Note: I am a beginner OHDSI user.. so it is likely that I may not understand important architecture issues...

However, the issue that I am concerned about is the fact that the Broadsea repo does not refer directly to Hades.

Instead, it refers to an intermediate repository, Broadsea-Hades.

It appears that this is the place where the static dependency on R 4.2.1 is maintained. This is not the case with the reference to Atlas etc. The seem to refer directly from Broadsea to the components directly.

After hacking here at the OHDSI conference, our best hypothesis is that this is the manner in which the specific R version is being enforced. However, it is not clear to us why the HADES repo cannot be used directly for these components.

We assume that this problem could be solved by:

  • Directly linking from the BroadSea repo to the HADES repo as a dependancy.
  • Documenting in the Broadsea-Hades repo the manner in which the middle repository is being generated and its reasons for being.

We had ambitions to contribute more documentation on how to get containers working with HADES and then possibly instructions for getting things going on Linux. However, without understanding the reasoning for the middle-repo between the two projects we are hesitant to write something presumptive.

-ft

@alondhe
Copy link

alondhe commented Oct 26, 2023

We've been shifting away from specific Broadsea sub-repos and just building everything in the main Broadsea repo thanks to Docker profiles allowing users to pick and choose what services they want.

For Hades, we're working on using an image with the renv.lock file from Hades, so we can stay in sync. More to come soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants