Skip to content

Commit

Permalink
fuzz/detect: forbid rule with pcre only on stream
Browse files Browse the repository at this point in the history
to avoid fuzzing blocks on timeouts with known bad rules

Ticket: 4858
  • Loading branch information
catenacyber authored and victorjulien committed Oct 14, 2024
1 parent 81f7ef8 commit 378f678
Showing 1 changed file with 19 additions and 0 deletions.
19 changes: 19 additions & 0 deletions src/detect-content.c
Original file line number Diff line number Diff line change
Expand Up @@ -453,6 +453,25 @@ void SigParseRequiredContentSize(
*/
bool DetectContentPMATCHValidateCallback(const Signature *s)
{
#ifdef FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION
bool has_pcre = false;
bool has_content = false;
for (SigMatch *sm = s->init_data->smlists[DETECT_SM_LIST_PMATCH]; sm != NULL; sm = sm->next) {
if (sm->type == DETECT_PCRE) {
has_pcre = true;
} else if (sm->type == DETECT_CONTENT) {
has_content = true;
break;
}
}
if (has_pcre && !has_content) {
// Fuzzing does not allow rules with pcre and without content on payload
// as it is known to be a bad rule for performance causing possible timeouts
// Engine analysis has more generic warn_pcre_no_content about this
return false;
}
#endif

if (!(s->flags & SIG_FLAG_DSIZE)) {
return true;
}
Expand Down

0 comments on commit 378f678

Please sign in to comment.