Minor Streaming buffer cleanups/v1 #10161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StreamingBuffer is not required to find the intersecting regions, so, don't pass it as a param to the fn.
If the node was successfully added in the RB Tree, the INSERT macro should return NULL. Check for the retval of the macro and free the resources and return from the fn with an error if the node was not added successfully for some reason.
inashivb
commented
Jan 15, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #10161 +/- ##
==========================================
- Coverage 82.19% 82.09% -0.10%
==========================================
Files 974 974
Lines 271825 271829 +4
==========================================
- Hits 223416 223152 -264
- Misses 48409 48677 +268
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 17510 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.