Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cppcheck/v1 #11946

Closed
wants to merge 6 commits into from
Closed

Cppcheck/v1 #11946

wants to merge 6 commits into from

Commits on Oct 12, 2024

  1. stream: track pcap log segments timestamp with SCTime_t 

    This is a more compact time format.
    @victorjulien
    victorjulien committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    0b259cd View commit details
    Browse the repository at this point in the history

  2. time: remove unused function 

    It tripped up cppcheck:

src/util-time.h:124:35: error: syntax error [syntaxError]
    return !timercmp(first, second, >);
    @victorjulien
    victorjulien committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    0a5de98 View commit details
    Browse the repository at this point in the history

  3. util/hash-string: fix compile warning 

    Clang 19:

util-hash-string.c:41:16: error: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Werror,-Wshorten-64-to-32]
   41 |     int len1 = strlen((char *)data1);
      |         ~~~~   ^~~~~~~~~~~~~~~~~~~~~
util-hash-string.c:42:16: error: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Werror,-Wshorten-64-to-32]
   42 |     int len2 = strlen((char *)data2);
      |         ~~~~   ^~~~~~~~~~~~~~~~~~~~~
2 errors generated.
    @victorjulien
    victorjulien committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    80ed2e3 View commit details
    Browse the repository at this point in the history

  4. time: add SCTIME_CMP_EQ

    @victorjulien
    victorjulien committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    8cd1d31 View commit details
    Browse the repository at this point in the history

  5. threads: track wall clock time precisely 

    Issue warning if thread sleeps for a long time.
    @victorjulien
    victorjulien committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    c245e70 View commit details
    Browse the repository at this point in the history

  6. util/var-names: switch to SCTime_t

    @victorjulien
    victorjulien committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    bd72dc0 View commit details
    Browse the repository at this point in the history