detect/http: fix progress for headers keywords #11977
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 7326 Having a lower progress than the right one, made prefilter bail out too early, not having found a buffer in the multi-buffer that mathed the prefilter. Hence, we got false negatives, if http.request_header or http.response_header was used as fast pattern, and if the request or response came in multiple packets, and the first of these packets did not have enough data (like only http request line), and the next packets did have the matching data.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11977 +/- ##
==========================================
- Coverage 82.77% 82.66% -0.12%
==========================================
Files 910 910
Lines 249016 249016
==========================================
- Hits 206134 205848 -286
- Misses 42882 43168 +286
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 23121 |
|
Hi @catenacyber ! Could you please tell what does "right one" mean in your commit message "Having a lower progress than the right one.."? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7326
Describe changes:
SV_BRANCH=OISF/suricata-verify#2094
Should we have the generic fix of
DetectAppLayerMultiRegisterusing only one tx progress ?#11968 with better commit message