Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next/603/20241017/v1 #11980

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Conversation

dependabot bot and others added 4 commits October 16, 2024 04:28
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.12 to 3.26.13.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Commits](github/codeql-action@v3.26.12...v3.26.13)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Wrong function call caused `issuerdn` to be logged when
`subjectaltname` was enabled, for custom logging, only.

Bug OISF#7332
Since enabling custom logging will replace the extended logging, thus
possibly leading to certain fields disappearing from the logs, mention
this aspect.

Related to
Bug OISF#7333
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.75%. Comparing base (37fa2a6) to head (55b922c).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11980      +/-   ##
==========================================
- Coverage   82.77%   82.75%   -0.03%     
==========================================
  Files         910      910              
  Lines      249016   249016              
==========================================
- Hits       206134   206069      -65     
- Misses      42882    42947      +65     
Flag Coverage Δ
fuzzcorpus 60.81% <0.00%> (+0.03%) ⬆️
livemode 18.71% <0.00%> (ø)
pcap 44.12% <0.00%> (+0.04%) ⬆️
suricata-verify 62.28% <100.00%> (+0.09%) ⬆️
unittests 59.00% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 23123

Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@victorjulien victorjulien merged commit 55b922c into OISF:master Oct 17, 2024
61 checks passed
@victorjulien victorjulien deleted the next/603/20241017/v1 branch October 17, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants