Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoicepe Preprod Logs (Invoice Based Loans) #1707

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

Avijeet-Blocsol
Copy link
Contributor

Looking forward to your feedback

@92shreyansh 92shreyansh added FIS-12 Financial Services - Credit IGM Issue & Grievence Management labels Sep 24, 2024
@sourabhsaini11
Copy link

@Avijeet-Blocsol, you have multiple open PR (161), PR(1562 present for Invoice-loan. Either get those PR's closed or continue using the old threads only.

@Avijeet-Blocsol
Copy link
Contributor Author

Avijeet-Blocsol commented Sep 26, 2024 via email

@Avijeet-Blocsol
Copy link
Contributor Author

Avijeet-Blocsol commented Sep 30, 2024 via email

@sourabhsaini11
Copy link

@Avijeet-Blocsol, please get below issues fixed
Common issue

  • INSTALLMENT range should change to year 2025 after the 2024 (December) installment at payments.

Flow 1

on_search_1

  • Xinput.headings should be "organization information".

on_select_1

  • tags.descriptor.interest rate conversion charges value should be "NA".

on_init_1

  • Provider.tags missing.
  • tags.descriptor.interest rate conversion charges value should be "NA".

on_confirm

  • fulfillment.state should be "SANCTIONED".

Flow 2

on_update_3

  • DISBURSED cancel state is missing in cancellation_terms.
  • LOAN_CANCELLATION doc ID missing in documents.
  • Multiple PRE_PART_PAYMENT objects are present in payments; only a single object containing label as PRE_PART_PAYMENT should be there.

on_update_4

  • Multiple PRE_PART_PAYMENT objects are present in payments; only a single object containing label as PRE_PART_PAYMENT should be there.
  • INSTALLMENT object status should change to "DEFERRED" upon PRE_PART_PAYMENT (refer to API documentation for more info).

Flow 3

on_update_5

  • quote.price value is changed between /on_update 4 and /on_update 5.

@Avijeet-Blocsol
Copy link
Contributor Author

Hello Team,

We have updated the flow 1 logs. A few observations:

  1. tags.descriptor.interest rate conversion charges value should be "NA".

In case the value of the charges are zero, why is there is requirement for NA. Buyer applications parsing numerical values from the string will face unnecessary errors.

  1. fulfillment.state should be "SANCTIONED" in on_confirm:

Pramaan provides the ability to mark the loan as sanctioned separately which is the reason it is not SANCTIONED in on_confirm but in the corresponding on_status.

For Flow 2 and Flow 3, the pointed conflicts are with the Pramaan tool. Let us know in case it is a blocker. We will get in touch with the team to get this resolved at the earliest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FIS-12 Financial Services - Credit IGM Issue & Grievence Management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants