Pre-prod Tech Logs for TRV11 #1715

dunowgithub · 2024-09-27T06:52:21Z

Pre-prod Tech Logs for TRV11

gitguardian · 2024-09-27T06:52:56Z

⚠️ GitGuardian has uncovered 28 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
7620759	Triggered	Generic High Entropy Secret	`55a5810`	TRV11/Miles_Kilometres/Flow 1/on_confirm.json	View secret
7620759	Triggered	Generic High Entropy Secret	`a996508`	TRV11/Miles_Kilometres/Flow 1/on_status.json	View secret
7620759	Triggered	Generic High Entropy Secret	`a95b13d`	TRV11/Miles_Kilometres/Flow 1/on_status.json	View secret
7620759	Triggered	Generic High Entropy Secret	`a996508`	TRV11/Miles_Kilometres/Flow 1/on_confirm.json	View secret
7620759	Triggered	Generic High Entropy Secret	`d062b5e`	TRV11/Miles_Kilometres/on_status.json	View secret
7620759	Triggered	Generic High Entropy Secret	`cf2f30e`	TRV11/Miles_Kilometres/Flow 1/on_confirm.json	View secret
7620759	Triggered	Generic High Entropy Secret	`55a5810`	TRV11/Miles_Kilometres/Flow 1/on_confirm.json	View secret
7620759	Triggered	Generic High Entropy Secret	`a95b13d`	TRV11/Miles_Kilometres/Flow 1/on_status.json	View secret
7620759	Triggered	Generic High Entropy Secret	`cf2f30e`	TRV11/Miles_Kilometres/Flow 1/on_confirm.json	View secret
7620759	Triggered	Generic High Entropy Secret	`e375a49`	TRV11/Miles_Kilometres/Flow 1/on_status.json	View secret
7620759	Triggered	Generic High Entropy Secret	`d062b5e`	TRV11/Miles_Kilometres/on_status.json	View secret
7620759	Triggered	Generic High Entropy Secret	`a95b13d`	TRV11/Miles_Kilometres/Flow 1/on_status.json	View secret
7620759	Triggered	Generic High Entropy Secret	`9efa9e5`	TRV11/Miles_Kilometres/Flow 1/on_status.json	View secret
7620759	Triggered	Generic High Entropy Secret	`b0e6a62`	TRV11/Miles_Kilometres/Flow 1/on_confirm.json	View secret
7620759	Triggered	Generic High Entropy Secret	`9efa9e5`	TRV11/Miles_Kilometres/Flow 1/on_status.json	View secret
7620759	Triggered	Generic High Entropy Secret	`55a5810`	TRV11/Miles_Kilometres/Flow 1/on_confirm.json	View secret
7620759	Triggered	Generic High Entropy Secret	`a996508`	TRV11/Miles_Kilometres/Flow 1/on_confirm.json	View secret
7620759	Triggered	Generic High Entropy Secret	`55a5810`	TRV11/Miles_Kilometres/Flow 1/on_confirm.json	View secret
7620759	Triggered	Generic High Entropy Secret	`a95b13d`	TRV11/Miles_Kilometres/Flow 1/on_status.json	View secret
7620759	Triggered	Generic High Entropy Secret	`a95b13d`	TRV11/Miles_Kilometres/Flow 1/on_status.json	View secret
7620759	Triggered	Generic High Entropy Secret	`a996508`	TRV11/Miles_Kilometres/Flow 1/on_confirm.json	View secret
7620759	Triggered	Generic High Entropy Secret	`a996508`	TRV11/Miles_Kilometres/Flow 1/on_status.json	View secret
7620759	Triggered	Generic High Entropy Secret	`55a5810`	TRV11/Miles_Kilometres/Flow 1/on_confirm.json	View secret
7620759	Triggered	Generic High Entropy Secret	`a996508`	TRV11/Miles_Kilometres/Flow 1/on_status.json	View secret
7620759	Triggered	Generic High Entropy Secret	`deb1b24`	TRV11/Miles_Kilometres/on_confirm.json	View secret
7620759	Triggered	Generic High Entropy Secret	`deb1b24`	TRV11/Miles_Kilometres/on_confirm.json	View secret
7620759	Triggered	Generic High Entropy Secret	`deb1b24`	TRV11/Miles_Kilometres/on_confirm.json	View secret
7620759	Triggered	Generic High Entropy Secret	`d062b5e`	TRV11/Miles_Kilometres/on_status.json	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

dunowgithub · 2024-09-27T06:54:23Z

@sourabhsaini11 Submitting TRV11 Pre-Prod Logs for your review. Let us know if you need anything else.

sourabhsaini11 · 2024-09-30T05:06:29Z

@dunowgithub, please submit /on_action calls and missing flows as well

dunowgithub · 2024-09-30T05:27:05Z

sourabhsaini11 - Missing files have been uploaded. Please check

sourabhsaini11 · 2024-10-01T04:04:53Z

@dunowgithub, please submit search_1 api pair call & seggregate calls on basis of flows as well

dunowgithub · 2024-10-01T04:38:03Z

sourabhsaini11 - Done. Please have a look. You may please delete the files that are outside the "Flow" folder

sourabhsaini11 · 2024-10-03T06:25:31Z

@dunowgithub, please fix below issue
search

collected_by is missing in payments
bpp_uri & bpp_id is missing in context (for /search_2 only)

dunowgithub · 2024-10-03T08:39:22Z

@dunowgithub, please fix below issue search

collected_by is missing in payments

bpp_uri & bpp_id is missing in context (for /search_2 only)

collected_by is missing in payments - This can be fixed
bpp_uri & bpp_id is missing in context (for /search_2 only) - Our Journey starts directly with Search_2. We cache the station codes and indicate that in START & END and wait for Sellers to respond. So we will NOT know bpp_i and bpp_uri. We will know only in on_search2 - So this should observation should be discarded.

dunowgithub · 2024-10-03T09:45:06Z

@dunowgithub, please fix below issue search

collected_by is missing in payments

bpp_uri & bpp_id is missing in context (for /search_2 only)

Over to you..

#1) collected_by is missing in payments - FIXED
#2) bpp_uri & bpp_id is missing in context (for /search_2 only) - Our Journey starts directly with Search_2. We cache the station codes and indicate that in START & END and wait for Sellers to respond. So we will NOT know bpp_id and bpp_uri. We will know only in on_search2 - So this should observation should be discarded.

sourabhsaini11 · 2024-10-07T18:05:12Z

@dunowgithub, please get below issues fixed as well
common_issue

tag SETTLEMENT_WINDOW value mismatch between /action & /on_action calls

search1

payment.collected_by is missing

confirm

bank_account_number & bank_code are mising in params

dunowgithub · 2024-10-08T02:02:28Z

@dunowgithub, please get below issues fixed as well common_issue

tag SETTLEMENT_WINDOW value mismatch between /action & /on_action calls

search1

payment.collected_by is missing

confirm

bank_account_number & bank_code are mising in params

Hey,

We are committing to settlement to the seller in 3 days though the seller wants in 30 days. How is that a problem?

dunowgithub · 2024-10-08T02:28:18Z

@dunowgithub, please get below issues fixed as well common_issue

tag SETTLEMENT_WINDOW value mismatch between /action & /on_action calls

search1

payment.collected_by is missing

confirm

bank_account_number & bank_code are mising in params

Hey,

We are committing to settlement to the seller in 3 days though the seller wants in 30 days. How is that a problem?

Whose bank_account_number & bank_code are mising in params?

dunowgithub · 2024-10-08T15:22:03Z

@dunowgithub, please get below issues fixed as well common_issue

tag SETTLEMENT_WINDOW value mismatch between /action & /on_action calls

search1

payment.collected_by is missing

confirm

bank_account_number & bank_code are mising in params

#1) As long as our settlement window is lesser than that of the SELLER - I do not see any reason why this should be a show stopper - Let me know if you think otherwise

#2) search1 - We have provided the logs.

#3) Have added bank_account_number & bank_code as asked

Have submitted the following

search1/on_search1
search2/on_search2
init/on_init
confirm/on_confirm
status/on_status
cancel/on_cancel
cancel2/on_cancel2

sourabhsaini11 · 2024-10-10T15:19:24Z

@dunowgithub, please fix the below issues
common_issue

tag SETTLEMENT_WINDOW value mismatch between /action & /on_action calls (what if BPP is asking P1D or PT1H as SETTLEMENT_WINDOW instead of P30D, will you guys still settle for P3D or agree to settle at their time-frame. Thus in such cases there's need to be clear terms defined in the contract or such discrepancy will occur)

on_confirm

fulfillments.id & payments.id mismatch between /on_init & /on_confirm

Pre-prod Tech Logs for TRV11

d062b5e

Pre-prod Tech Logs for TRV11

Add files via upload

deb1b24

dunowgithub added 3 commits October 1, 2024 09:52

Add files via upload

a996508

Create on_search1.json

a6ecfad

Create search1.json

1c29321

92shreyansh added the TRV-11 Unreserved-Ticket label Oct 3, 2024

dunowgithub added 13 commits October 3, 2024 15:08

Update search2.json

80f8dd8

Update on_search2.json

a854788

Update search2.json

de26379

Update init.json

68786ab

Update on_init.json

c753c83

Update confirm.json

2b2c761

Update on_confirm.json

55a5810

Update status.json

f24fe1c

Update on_status.json

a95b13d

Update cancel.json

77c3d23

Update on_cancel.json

6de55bd

Update cancel2.json

9724d88

Update on_cancel2.json

41a80e2

dunowgithub added 26 commits October 8, 2024 18:58

Update search2.json

d0a2eae

Update on_search2.json

727faed

Update init.json

b4d4509

Update on_init.json

9033c63

Update confirm.json

9c372db

Update on_confirm.json

cf2f30e

Update status.json

1285579

Update on_status.json

9efa9e5

Update cancel.json

bcee06b

Update on_cancel.json

bba6d33

Update cancel2.json

06e6d80

Update on_cancel2.json

43da6c4

Update search1.json

6e42e8d

Update on_search1.json

afcd6c6

Update search2.json

8bed805

Update on_search2.json

4e2ff1b

Update init.json

148aa20

Update on_init.json

1291aa8

Update confirm.json

353cf0d

Update on_confirm.json

b0e6a62

Update status.json

41a70e5

Update on_status.json

e375a49

Update cancel.json

a3ff5c1

Update on_cancel.json

812c6fb

Update cancel2.json

78a9c2c

Update on_cancel2.json

3b2548b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pre-prod Tech Logs for TRV11 #1715

Pre-prod Tech Logs for TRV11 #1715

dunowgithub commented Sep 27, 2024

gitguardian bot commented Sep 27, 2024 •

edited

Loading

dunowgithub commented Sep 27, 2024

sourabhsaini11 commented Sep 30, 2024

dunowgithub commented Sep 30, 2024

sourabhsaini11 commented Oct 1, 2024

dunowgithub commented Oct 1, 2024

sourabhsaini11 commented Oct 3, 2024

dunowgithub commented Oct 3, 2024

dunowgithub commented Oct 3, 2024

sourabhsaini11 commented Oct 7, 2024

dunowgithub commented Oct 8, 2024

dunowgithub commented Oct 8, 2024

dunowgithub commented Oct 8, 2024

sourabhsaini11 commented Oct 10, 2024

Pre-prod Tech Logs for TRV11 #1715

Are you sure you want to change the base?

Pre-prod Tech Logs for TRV11 #1715

Conversation

dunowgithub commented Sep 27, 2024

gitguardian bot commented Sep 27, 2024 • edited Loading

⚠️ GitGuardian has uncovered 28 secrets following the scan of your pull request.

dunowgithub commented Sep 27, 2024

sourabhsaini11 commented Sep 30, 2024

dunowgithub commented Sep 30, 2024

sourabhsaini11 commented Oct 1, 2024

dunowgithub commented Oct 1, 2024

sourabhsaini11 commented Oct 3, 2024

dunowgithub commented Oct 3, 2024

dunowgithub commented Oct 3, 2024

sourabhsaini11 commented Oct 7, 2024

dunowgithub commented Oct 8, 2024

dunowgithub commented Oct 8, 2024

dunowgithub commented Oct 8, 2024

sourabhsaini11 commented Oct 10, 2024

gitguardian bot commented Sep 27, 2024 •

edited

Loading