Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation enhancement #3703

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

goratt12
Copy link
Collaborator

PR Checklist

PR Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Developer experience (improves developer workflows for contributing to the project)

Description

What this PR does

Git Issues

Closes #

Screenshots/Videos

If useful, provide screenshot or capture to highlight main changes


What happens next?

Thanks for the contribution! We try to make sure all PRs are reviewed ahead of our monthly maintainers call (first Monday of the month)

If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.

If you need more immediate feedback you can try reaching out on Discord in the Community Platform development channel.

@goratt12
Copy link
Collaborator Author

I just realized I created this branch out of the "move notification logic from discussion store to firebase functions" branch.
So will we wait for the said branch to be merged (and then no problem) or should I create a new branch/pr?

@goratt12 goratt12 marked this pull request as ready for review September 7, 2024 18:25
@goratt12 goratt12 requested a review from a team as a code owner September 7, 2024 18:25
FAST_REFRESH: false,
}

exports.cra = cra
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this still needed? we shouldn't use cra or webpack anymore

@benfurber benfurber added the 🤝 Awaiting author Waiting on action from the author label Sep 26, 2024
@benfurber
Copy link
Member

@goratt12 Should we just close this? What's needed to get it merged in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤝 Awaiting author Waiting on action from the author Backend Documentation
Projects
Status: No status
Status: 💬 Changes Requested/with author
Development

Successfully merging this pull request may close these issues.

3 participants