-
-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update profile tags display #4002
base: master
Are you sure you want to change the base?
Conversation
@davehakkens This is what I'm able to do quickly with the multi-select field to add some more interest. I could implement the full design but it would require 1-3 days of dev as I'd need to use a completely different component for the field and I'm not sure it's worth doing that at this stage. Thoughts? |
Cool. But I thought we skipped using the colors for this? (because they can overlap between different spaces and don't align with the academy colors) Or what logic do you apply to choose a color? |
@davehakkens Oh OK, I thought we decided to prioritise adding extra styling to this and so I went off what was on the final design tag. I'm processing now your comments. The draft colors I selected link the 'old' PP profile type custom fields. |
1ea5ad4
to
5824b76
Compare
onearmy-community-platform Run #6556
Run Properties:
|
Project |
onearmy-community-platform
|
Branch Review |
pull/4002
|
Run status |
Passed #6556
|
Run duration | 05m 16s |
Commit |
5824b76a40: feat: add limit to tag selector
|
Committer | Ben Furber |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
1
|
Pending |
0
|
Skipped |
0
|
Passing |
74
|
View all changes introduced in this branch ↗︎ |
Agree we should do some final styling comments, (round borders etc) However also dont mind if the feature is there. Just dont think PP or PK are ready to properly use it at this point. |
PR Checklist
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?