Skip to content

Commit

Permalink
Merge pull request 'Fix Bug 72462' (#221) from fix/bugfix into releas…
Browse files Browse the repository at this point in the history
…e/v8.3.0
  • Loading branch information
Julia Radzhabova committed Jan 13, 2025
2 parents b81516a + 8295fd3 commit f38c8e3
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion apps/common/main/lib/controller/Comments.js
Original file line number Diff line number Diff line change
Expand Up @@ -996,7 +996,7 @@ define([
this.getPopover().saveText();
this.getPopover().hideTips();

if (posY < 0 || this.getPopover().sdkBounds.height < posY || (!_.isUndefined(leftX) && this.getPopover().sdkBounds.width < leftX)) {
if (posY < 0 || this.getPopover().sdkBounds.outerHeight < posY || (!_.isUndefined(leftX) && this.getPopover().sdkBounds.width < leftX)) {
this.getPopover().hide();
} else {
if (this.isModeChanged)
Expand Down
2 changes: 1 addition & 1 deletion apps/common/main/lib/controller/ReviewChanges.js
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ define([
saveTxtReplyId = '';

if (this.getPopover()) {
if (posY < 0 || this.getPopover().sdkBounds.height < posY) {
if (posY < 0 || this.getPopover().sdkBounds.outerHeight < posY) {
this.getPopover().hide();
} else if (this.popoverChanges.length>0) {
if (!this.getPopover().isVisible())
Expand Down
6 changes: 3 additions & 3 deletions apps/common/main/lib/view/ReviewPopover.js
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ define([
_options.tpl = _.template(this.template)(_options);

this.arrow = {margin: 20, width: 10, height: 30};
this.sdkBounds = {width: 0, height: 0, padding: 10, paddingTop: 20};
this.sdkBounds = {width: 0, height: 0, outerWidth: 0, outerHeight: 0, padding: 10, paddingTop: 20};

Common.UI.Window.prototype.initialize.call(this, _options);

Expand Down Expand Up @@ -772,8 +772,8 @@ define([

this.$window.css({maxHeight: sdkBoundsHeight + 'px'});

this.sdkBounds.width = editorBounds.width;
this.sdkBounds.height = editorBounds.height;
this.sdkBounds.width = this.sdkBounds.outerWidth = editorBounds.width;
this.sdkBounds.height = this.sdkBounds.outerHeight = editorBounds.height;

// LEFT CORNER

Expand Down

0 comments on commit f38c8e3

Please sign in to comment.