-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Matrix-free cuda #204
base: master
Are you sure you want to change the base?
Conversation
AFAICT the only problem left is with the coarse solver, i.e. replacing it by the identity gives the same results for 1 and 2 MPI processes. |
I see the same test failure locally as
|
…igenvalues using lanczos
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
==========================================
- Coverage 89.66% 89.11% -0.55%
==========================================
Files 57 58 +1
Lines 3250 3270 +20
==========================================
Hits 2914 2914
- Misses 336 356 +20
Continue to review full report at Codecov.
|
It seems like we need to update |
I guess someone jumped the gun in deal.II moving from |
Just for the record: the main problem is that you would expect |
I pushed |
Still does not pass |
All the |
yeah but for that the |
But that is due to updating |
I just checked that the test fails for the previous commit as well. |
Seems like e4fe1b806f6d086218cae85c58342815c7cef55a is guilty. |
The corresponding pull request is https://github.com/dealii/dealii/pull/8128/files. I am really confused about how that can make any difference for the |
Reverting the changes in that pull request (on top of |
This PR is very much a WIP, there is no need to look at it except for @masterleinad :) The things that need to be done in order of priority:
locally_relevant_global_diag
.locally_relevant_global_diag
is computed on the host because we can't get the diagonal from matrix-free with cuda.Right now we don't useThis can be done in another PRmaterial_property
when using cuda matrix-free, so we need to add that.This is all the work that still needs to be done on this PR. Once it's done we can do some cleaning and split this PR in smaller ones. If you can tackle the first two points that would be fantastic but feel free to do more if you are bored 😄