Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Ticket Improvements based on Stijn issue #4094

Closed
wants to merge 1 commit into from

Conversation

abujeda
Copy link
Contributor

@abujeda abujeda commented Jan 24, 2025

Based on the request from Stijn in issue #4055.

  • Added support to add HTML in the support ticket description
  • Added support to add custom javascript file to the support ticket page

Fixes #4055

@johrstrom
Copy link
Contributor

I know you have another PR too that I haven't looked at. I'm trying, but there'll be a little delay.

@abujeda abujeda force-pushed the 4055_support_ticket_improvements branch from cfd3f88 to 7f24e24 Compare January 24, 2025 21:42
@johrstrom
Copy link
Contributor

Can you tell me how we don't already support this?

  • You can override the partial to provide any HTML you like
  • You can drop javascript files in a public directory and reference them through the HTML you overrode.

@abujeda
Copy link
Contributor Author

abujeda commented Jan 27, 2025

Both are true. There is nothing new in this PR that you cannon do with other approaches.

The description HTML support is simply more convenient than overriding the whole template in case you need a more complex description at the top of the form. Something with headers and paragraphs.

For the javascript update, comes from the idea of only including the javascript in the pages that is used/required. This might be an old fashion way of looking into this, but for me seems better than always including the file.

@johrstrom
Copy link
Contributor

Then I would ask politely if we can close this. I know it's not a big addition, but calling html_safe does worry me a bit.

Moreover, given we already support it, I'd just like to avoid more things to maintain. Again, not a lot of additions, but we're responsible for every single one and it's just completely draining especially given the fact that it's already possible.

@abujeda
Copy link
Contributor Author

abujeda commented Jan 27, 2025

OK - makes sense. Closing.

@abujeda abujeda closed this Jan 27, 2025
@johrstrom
Copy link
Contributor

Thanks! I don't mean to be that way, I just feel like the only way to not give a mile is not not give an inch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support ticket features
3 participants