Updated the project directory permission allowing group to read and execute files #4129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johrstrom
reviewed
Feb 10, 2025
apps/dashboard/app/models/project.rb
Outdated
| @@ -253,6 +253,15 @@ def make_dir | |||
| false | |||
| end | |||
|
|
|||
| def updated_permission | |||
| # Read and execute to others | |||
| project_dataroot.chmod(0775) | |||
There was a problem hiding this comment.
Seems like we should use 0750 for a little bit of safety.
harshit-soora
force-pushed
the
master
branch
from
239e150 to
70ad935
Compare
|
Mistakenly closed while rebasing with master |
harshit-soora
changed the title
|
Looks fine, went to merge, but your commit isn't correctly associated with your github user. The email address associated with the commit is a very strange one.
|
|
I removed the “comment statement” to add another git commit. Last time I missed to configure my name and email. I hope now we are okay to merge. |
|
Yea it's fine, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Issue #4121
By default directory permissions were rwxr-xr-x.
This is updated to rwxr-x---, thus groups can also read and execute the files inside of the project directory (as before) while others will have no permissions to ensure safety.
Locally tested the changes with OOD master branch instance running on OOD.