Added a form to projects to import a shared-project using directory path #4178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johrstrom
reviewed
Feb 24, 2025
Comment on lines
+7
to
+10
| <%= bootstrap_form_for(@project, url: project_import_save_path, method: :post) do |form| %> | ||
| <%= render partial: "form", locals: { form: form }%> | ||
| <% end %> |
There was a problem hiding this comment.
I think we need a new partial for this. I'm thinking it'll look a lot like the index with a list of cards. Maybe there's a simple search? Maybe you can expand the cards to see more details?
In any case, I'd say let's just put a TODO here and reset the _form.html.erb.
harshit-soora
force-pushed
the
pr1-form
branch
from
867e601 to
f8d5357
Compare
|
Review comments considered and rebased with master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Issue #4120
This is the first PR, to add the blueprint of the form that will allow a user to fill in the shared project path.
This path will later be saved into the user's .lookup-file