Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GTiff: CreateCopy(): fix incorrect writing of mask band when COPY_SRC_OVERVIEWS=YES and INTERLEAVE=BAND (master only) #11857

Merged
merged 1 commit into from
Feb 17, 2025
Merged

GTiff: CreateCopy(): fix incorrect writing of mask band when COPY_SRC_OVERVIEWS=YES and INTERLEAVE=BAND (master only) #11857

merged 1 commit into from
Feb 17, 2025
+33 −55

Conversation

rouault
Copy link
Member

@rouault rouault commented Feb 17, 2025

Fixes #11851

@rouault
GTiff: CreateCopy(): fix incorrect writing of mask band when COPY_SRC…
3960fc8 
…_OVERVIEWS=YES and INTERLEAVE=BAND (master only)

Fixes OSGeo#11851
@rouault rouault mentioned this pull request Feb 17, 2025
Closed
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 70.038% (-0.001%) from 70.039%
when pulling 3960fc8 on rouault:fix_11851
into af5e6c2 on OSGeo:master.

@schwehr schwehr self-requested a review February 17, 2025 22:39
schwehr
schwehr approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@schwehr schwehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Confirmed this fixes the original issue represented by the test that @orglofch shared.

@rouault rouault merged commit 6773dd0 into OSGeo:master Feb 17, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schwehr schwehr schwehr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GTiff driver: CreateCopy doesn't preserve mask on band interleaved COGs
3 participants
@rouault @coveralls @schwehr