Fix build when iterators are raw pointers #11880
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to OSGeo#11879, `typename Iterator` might be just a raw pointer. The most corrent way would be using `std::iterator_traits` to get the type properly, but it seems that current static_cast can be simply removed.
|
There's a typo in this commit (extra parenthesis), but I would be more confortable if this change was submitted upstream to https://github.com/p-ranav/argparse and accepted there prior to here |
|
Thanks! |
|
I filed an upstream PR here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #11879,
typename Iteratormight be just a raw pointer. The most corrent way would be usingstd::iterator_traitsto get the type properly, but it seems that current static_cast can be simply removed.