Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Prepare introduction of ruff and ruff format #1296

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

echoix
Copy link
Member

@echoix echoix commented Feb 2, 2025

I'm preparing the repo to use ruff and ruff format, like the main repo.

Most of the changes here are to apply non-conflicting changes, in other words, ruff format changes that are not reverted by the current black style. It will make reviewing the next PRs easier.

Copy link
Contributor

@cwhite911 cwhite911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Didn't realized we switched from Black.

Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked just couple files at random while scrolling through it, but it looks good.

@echoix
Copy link
Member Author

echoix commented Feb 3, 2025

I checked just couple files at random while scrolling through it, but it looks good.

There were all correct, except 2 or 3 places. 1 had a implicit string concatenation merged together and it had an extra space between sentences that I removed, and 1 or 2 had a comma after the print, making a tuple, similar to what we fixed in the main repo yesterday/today.

@echoix
Copy link
Member Author

echoix commented Feb 3, 2025

Cool! Didn't realized we switched from Black.

It was discussed since a month, but it was implemented this weekend and merged this afternoon. So you're not late on the news haha

@echoix echoix merged commit ff444aa into OSGeo:grass8 Feb 3, 2025
7 checks passed
@echoix echoix deleted the prepare-ruff-format branch February 3, 2025 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants