Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r.sun: fix -Wimplicit-int warnings #3097

Merged
merged 1 commit into from
Aug 6, 2023

Conversation

nilason
Copy link
Contributor

@nilason nilason commented Jul 24, 2023

This is a partial, manual backport of #1405.

The warning is treated as an error by Clang 16+ and the compilation fails.

Considering next 7.8 release likely will be the last, this should be a blocker.

@nilason nilason added blocker Blocking a release C Related code is in C labels Jul 24, 2023
@nilason nilason added this to the 7.8.8 milestone Jul 24, 2023
@nilason nilason added the bug Something isn't working label Jul 24, 2023
@wenzeslaus
Copy link
Member

Please, link a PR which is merged. #1405 is closed without merging and this change which comments out code requires at least some explanation.

For now only comments out relevant parts.
Addresses -Wimplicit-int compiler warnings.
The warning is treated as an error by Clang 16+ and the compilation fails.

This is a partial, manual backport of OSGeo#1405,
commit 594c947.
@nilason
Copy link
Contributor Author

nilason commented Jul 31, 2023

Please, link a PR which is merged. #1405 is closed without merging and this change which comments out code requires at least some explanation.

That PR was created just before the change to "Squash and merge"-only policy, so I cherry picked and pushed each commit in the PR manually (to keep each fix separate). But you're right about the lack of explanation, I incorporated the original commit message with updates:

r.sun: remove unused function 'cube'

For now only comments out relevant parts.
Addresses -Wimplicit-int compiler warnings.
The warning is treated as an error by Clang 16+ and the compilation fails.

This is a partial, manual backport of #1405,
commit 594c947.

Copy link
Member

@neteler neteler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compilation tested fine with gcc version 12.3.1 on Fedora 37.

@nilason nilason merged commit 5be073a into OSGeo:releasebranch_7_8 Aug 6, 2023
8 checks passed
@nilason nilason deleted the fix_implicit_int_78 branch August 8, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Blocking a release bug Something isn't working C Related code is in C
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants