Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r.proj: Create unit tests #4225

Merged
merged 5 commits into from
Sep 10, 2024
Merged

r.proj: Create unit tests #4225

merged 5 commits into from
Sep 10, 2024

Conversation

cyliang368
Copy link
Contributor

@cyliang368 cyliang368 commented Aug 25, 2024

This PR creates unit tests for the r.proj. The results are checked by the extents, nrows, ncols, and statistics of the reprojected raster.

Closes #1663

@github-actions github-actions bot added raster Related to raster data processing Python Related code is in Python module tests Related to Test Suite labels Aug 25, 2024
raster/r.proj/testsuite/test_rproj.py Outdated Show resolved Hide resolved
raster/r.proj/testsuite/test_rproj.py Outdated Show resolved Hide resolved
raster/r.proj/testsuite/test_rproj.py Show resolved Hide resolved
@petrasovaa
Copy link
Contributor

Should we close #1663?

@echoix
Copy link
Member

echoix commented Aug 28, 2024

Should we close #1663?

Does it contain some useful parts that could be taken here?

@echoix
Copy link
Member

echoix commented Sep 9, 2024

Should we close #1663?

Does it contain some useful parts that could be taken here?

At first glance, I see that #1663 has more fields of the statistics in the expected results. Like sum, mean_of_abs, coeff_var, range. I don't see them mentioned in the current docs of r.proj, was it included at some point?

@cyliang368
Copy link
Contributor Author

Should we close #1663?

Does it contain some useful parts that could be taken here?

At first glance, I see that #1663 has more fields of the statistics in the expected results. Like sum, mean_of_abs, coeff_var, range. I don't see them mentioned in the current docs of r.proj, was it included at some point?

#1663 has everything from r.univar, but this is not necessary. For example, if max and min are determined, range will also be determined. mean can cover information for sum and mean_of_abs.

@echoix
Copy link
Member

echoix commented Sep 9, 2024

Ok, I see now how it's univar. In that case yes, I agree that the rest was kinda redundant. Like variance and stddev. So we can close the older PR then

@echoix echoix dismissed wenzeslaus’s stale review September 9, 2024 23:16

All changes have been addressed

@echoix echoix enabled auto-merge (squash) September 9, 2024 23:18
@echoix
Copy link
Member

echoix commented Sep 9, 2024

I misspressed on update instead of merge (very slow network), so we'll need to wait..

@echoix echoix disabled auto-merge September 9, 2024 23:19
@echoix echoix enabled auto-merge (squash) September 9, 2024 23:19
@echoix echoix merged commit 997624b into OSGeo:main Sep 10, 2024
26 checks passed
@neteler neteler added this to the 8.5.0 milestone Sep 10, 2024
@wenzeslaus wenzeslaus removed their request for review September 12, 2024 20:23
Mahesh1998 pushed a commit to Mahesh1998/grass that referenced this pull request Sep 19, 2024
* create unit tests for r.proj

* change the source project

* update the validation values according to the map in the project

* remove shell cmd, update doc, modify precision
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module Python Related code is in Python raster Related to raster data processing tests Related to Test Suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants