grass.jupyter: importing display function from IPython.display #4476

rohannallamadge · 2024-10-08T09:56:30Z

importing display function from IPython.display to display the map image

wenzeslaus

Thank you. This is great. It looks like it is addressing the original idea in #4340.

I left two comments and I also modified the title to make it valid (there was a leading space) and I moved the referenced issue to the text.

wenzeslaus · 2024-10-14T19:01:59Z

python/grass/jupyter/map.py


-        return Image(self._filename)
+        return display(Image(self._filename))


Is return needed here? What does IPython.display.display function return?

Is return needed here? What does IPython.display.display function return?

No. We are not setting a display_id parameter, so IPython.display.display will return None.

python/grass/jupyter/map.py

cwhite911

Nice job working on this PR.

… display()

…rass into display_update

rohannallamadge · 2024-10-17T12:46:41Z

Added _repr_pretty_ method to provide a custom pretty representation in IPython environments
Ensures proper handling of recursive cycles by displaying "Map(...)" as a fallback

rohannallamadge · 2024-10-17T17:16:02Z

sir, is this correct PR ?

…ering

…rass into display_update

rohannallamadge · 2024-10-19T11:13:05Z

Removed the return statement from the show() method
Now using display() directly to handle image rendering inline, without returning an Image object

…rass into display_update

echoix · 2024-10-19T16:03:22Z

Seems like some basic code formatting and checking is still missing. Let us know once ready ;)

github-actions · 2024-10-19T17:23:16Z

python/grass/jupyter/map3d.py

+            Image,
+            display,
+        )  # pylint: disable=import-outside-toplevel
+


[ruff] _{reported by reviewdog 🐶}

Suggested change

rohannallamadge · 2024-10-19T18:19:50Z

sir, error

…ption.

github-actions · 2024-10-20T05:52:23Z

python/grass/jupyter/map.py

+            Image,
+            display,  # pylint: disable=import-outside-toplevel
+        )
+        display(Image(self._filename))


[black] _{reported by reviewdog 🐶}

Suggested change

display(Image(self._filename))

display(Image(self._filename))

petrasovaa · 2024-10-21T15:14:44Z

.pylintrc

@@ -652,5 +652,6 @@ min-public-methods=1

 # Exceptions that will emit a warning when being caught. Defaults to
 # "BaseException, Exception".
-overgeneral-exceptions=BaseException,
-                       Exception
+overgeneral-exceptions=BaseException,Exception


I don't see a need for this change

cwhite911 · 2024-10-26T22:35:39Z

.pylintrc

@@ -654,3 +654,5 @@ min-public-methods=1
 # "BaseException, Exception".
 overgeneral-exceptions=BaseException,
                       Exception
+


Remove extra lines.

github-actions · 2024-10-27T18:20:21Z

python/grass/jupyter/map3d.py

-
-        return Image(self._filename)
+        from IPython.display import (
+            Image,


[black] _{reported by reviewdog 🐶}

Suggested change

Image,

Image,

importing display function from IPython.display to display the map image

20bd453

github-actions bot added Python Related code is in Python libraries notebook labels Oct 8, 2024

Merge branch 'main' into display_update

653139e

rohannallamadge changed the title ~~importing display function from IPython.display~~ grass.jupyter: importing display function from IPython.display #4340 Oct 8, 2024

wenzeslaus changed the title ~~grass.jupyter: importing display function from IPython.display #4340~~ grass.jupyter: importing display function from IPython.display Oct 14, 2024

wenzeslaus requested changes Oct 14, 2024

View reviewed changes

cwhite911 suggested changes Oct 16, 2024

View reviewed changes

rohannallamadge added 4 commits October 17, 2024 16:06

grass.jupyter:Add _repr_pretty_ for better Jupyter/Quarto integration

e95c87d

Merge branch 'main' into display_update

4a8e906

grass.jupyter:update show() to return Image object instead of calling…

e5fb33c

… display()

Merge branch 'display_update' of https://github.com/rohannallamadge/g…

25345d9

…rass into display_update

petrasovaa requested a review from cwhite911 October 17, 2024 14:42

rohannallamadge added 2 commits October 18, 2024 18:10

git commit -m "Remove empty line as suggested by ruff"

fb89f80

Merge branch 'main' into display_update

be3b9d8

rohannallamadge requested a review from wenzeslaus October 18, 2024 16:05

rohannallamadge added 2 commits October 19, 2024 16:41

refactor: remove return from show() and use display() for inline rend…

66157e0

…ering

Merge branch 'display_update' of https://github.com/rohannallamadge/g…

8103055

…rass into display_update

rohannallamadge added 3 commits October 19, 2024 16:43

Merge branch 'main' into display_update

291030c

Removed empty line as suggested by ruff

0cc242a

Merge branch 'display_update' of https://github.com/rohannallamadge/g…

dcd7e56

…rass into display_update

rohannallamadge added 2 commits October 19, 2024 22:47

style: reformat import statements as suggested by black

05d9b90

Fix formatting of imports and remove duplicate display line

9db48cd

github-actions bot reviewed Oct 19, 2024

View reviewed changes

Update .pylintrc: fix overgeneral-exceptions and remove no-self-use o…

084d246

…ption.

github-actions bot reviewed Oct 20, 2024

View reviewed changes

rohannallamadge added 3 commits October 20, 2024 11:51

git commit -m "Fix formatting issues in parsetab.py"

53e86f9

Fix import organization based on review suggestion

6aef31c

Fix import organization based on review suggestion

d16bbf3

petrasovaa reviewed Oct 21, 2024

View reviewed changes

Fix formatting display line

ebc6a71

cwhite911 reviewed Oct 26, 2024

View reviewed changes

Fix formatting display line

e6a1395

github-actions bot reviewed Oct 27, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

grass.jupyter: importing display function from IPython.display #4476

grass.jupyter: importing display function from IPython.display #4476

rohannallamadge commented Oct 8, 2024 •

edited by wenzeslaus

Loading

wenzeslaus left a comment

wenzeslaus Oct 14, 2024

cwhite911 Oct 16, 2024

cwhite911 left a comment

rohannallamadge commented Oct 17, 2024 •

edited

Loading

rohannallamadge commented Oct 17, 2024 •

edited

Loading

rohannallamadge commented Oct 19, 2024

echoix commented Oct 19, 2024

github-actions bot Oct 19, 2024

rohannallamadge commented Oct 19, 2024

github-actions bot Oct 20, 2024

petrasovaa Oct 21, 2024

cwhite911 Oct 26, 2024

github-actions bot Oct 27, 2024


		return Image(self._filename)
		return display(Image(self._filename))

	display(Image(self._filename))

	display(Image(self._filename))

grass.jupyter: importing display function from IPython.display #4476

Are you sure you want to change the base?

grass.jupyter: importing display function from IPython.display #4476

Conversation

rohannallamadge commented Oct 8, 2024 • edited by wenzeslaus Loading

wenzeslaus left a comment

Choose a reason for hiding this comment

wenzeslaus Oct 14, 2024

Choose a reason for hiding this comment

cwhite911 Oct 16, 2024

Choose a reason for hiding this comment

cwhite911 left a comment

Choose a reason for hiding this comment

rohannallamadge commented Oct 17, 2024 • edited Loading

rohannallamadge commented Oct 17, 2024 • edited Loading

rohannallamadge commented Oct 19, 2024

echoix commented Oct 19, 2024

github-actions bot Oct 19, 2024

Choose a reason for hiding this comment

rohannallamadge commented Oct 19, 2024

github-actions bot Oct 20, 2024

Choose a reason for hiding this comment

petrasovaa Oct 21, 2024

Choose a reason for hiding this comment

cwhite911 Oct 26, 2024

Choose a reason for hiding this comment

github-actions bot Oct 27, 2024

Choose a reason for hiding this comment

rohannallamadge commented Oct 8, 2024 •

edited by wenzeslaus

Loading

rohannallamadge commented Oct 17, 2024 •

edited

Loading

rohannallamadge commented Oct 17, 2024 •

edited

Loading