Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

temporal: Add precise typing overloads to dataset_factory #4600

Merged
merged 7 commits into from
Oct 27, 2024
Merged

temporal: Add precise typing overloads to dataset_factory #4600

merged 7 commits into from
Oct 27, 2024

Commits on Oct 27, 2024

  1. temporal: Add precise typing overloads to dataset_factory 

    This enables type checkers like mypy or Pyright to understand the returned class from the string passed as the type argument
    @echoix
    echoix committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    442e7a4 View commit details
    Browse the repository at this point in the history

  2. temporal: Add typing overloads to dataset_factory

    @echoix
    echoix committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    238f418 View commit details
    Browse the repository at this point in the history

  3. temporal: Add dataset_factory implementation with str type for type a… 

    …rgument
    @echoix
    echoix committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    5152860 View commit details
    Browse the repository at this point in the history

  4. temporal: Remove dataset_factory overload that listed all literal types

    @echoix
    echoix committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    e52e568 View commit details
    Browse the repository at this point in the history

  5. temporal: Update dataset_factory file header

    @echoix
    echoix committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    eb1a788 View commit details
    Browse the repository at this point in the history

  6. temporal: Add dataset_factory overload with str type for type argument

    @echoix
    echoix committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    fb023d0 View commit details
    Browse the repository at this point in the history

  7. temporal: Accept None for id argument in dataset_factory overload as … 

    …used in existing calls
    @echoix
    echoix committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    a7d4b29 View commit details
    Browse the repository at this point in the history