Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/ogsf: fix possible overflow errors in gvld.c #4637

Merged
merged 1 commit into from
Nov 5, 2024
Merged

lib/ogsf: fix possible overflow errors in gvld.c #4637

merged 1 commit into from
Nov 5, 2024

Commits on Nov 1, 2024

  1. ogsf: fix possible overflow errors in gvld module 

    We were doing `(255 << 24)` which causes integer overflow
and positive number gets converted to negative number. We
were then assigning this to an unsigned integer in multiple
places, which does conversion in a different way.

For example: If we do unsigned int x = -20, `UINT_MAX + 1 - 20`
is assigned to x.

I do not think that's what is intended when we do
`ktrans = (255 << 24)`. Fix instances of that, by using an
unsigned int literal over int literal.

This issue was found using cppcheck tool.

Signed-off-by: Mohan Yelugoti <[email protected]>
    @ymdatta
    ymdatta committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    7a7a860 View commit details
    Browse the repository at this point in the history