python: Add typing to RPC server and Messenger #4639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hey would be released when unlocked (RuntimeError: release unlocked lock)
… c_library_server
…it is a multiprocessing.Connection object obtained from multiprocessing.Pipe
…Connection object obtained from multiprocessing.Pipe
…connection.Connection object obtained from multiprocessing.Pipe
… message_server()
…the variable is used
github-actions
bot
added
Python
ninsbl
approved these changes
Nov 2, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The common denominator here were all places that used connection objects from
multiprocessing.Pipe. The documentation comment was wrong, as it isn't the pipe that is used, but one of the two Connection objects.For the
multiprocessing.Lockobjects used, theacquire()andrelease()were changed to use a context manager, making sure (to the extents possible) that the resource is released even on errors. This was tested more than a month ago, in the same work where for the PR that did some profiling and benchmarking with hyperfine. (I was trying alternatives to this kind of RPC server, but I wasn't satisfied with what I got). However, the context manager and locks are a good practice that is valuable to include.While I did try to completely type the messages class and file, I reverted it as it wasn't that much clearer, only correctly understood with very new Python syntax, and changed lists to tuples. Nevertheless, type checking of the possible data received highlighted the fact that the docs (which I wrote the typing from) didn't include the "INFORMATION" level, as it was "unused". That is what is nice when type checking and using
Literal[]for expected values. So the docstring is updated in consequence.