Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: create versioned directory name of extracted tarball #4659

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nilason
Copy link
Contributor

@nilason nilason commented Nov 6, 2024

Extracting the tarball will with this create a containing directory named 'grass-x.y.z', where x, y, z stands for major, minor, micro/patch version.

Previously, the tarball created by CI was extracted to a directory named 'grass', which was a regression to accustomed and expected behaviour.

Extracting the tarball will with this create a containing directory named
'grass-x.y.z', where x, y, z stands for major, minor, micro/patch version.
@nilason nilason added this to the 8.4.1 milestone Nov 6, 2024
@nilason nilason requested a review from neteler November 6, 2024 10:55
@nilason nilason self-assigned this Nov 6, 2024
@github-actions github-actions bot added the CI Continuous integration label Nov 6, 2024
@nilason nilason changed the title CI/release: create versioned directory name of extracted tarball CI: create versioned directory name of extracted tarball Nov 6, 2024
@nilason nilason added the backport to 8.4 PR needs to be backported to release branch 8.4 label Nov 6, 2024
@nilason
Copy link
Contributor Author

nilason commented Nov 6, 2024

Now, I'm not sure whether this need to be backported at all. Isn't it the file in main that is triggered by addition of a tag?

@neteler
Copy link
Member

neteler commented Nov 6, 2024

Extracting the tarball

Just for clarification: where (in the CI?) is the tarball created? Because the release tarballs contain the version in the directory name.

@nilason
Copy link
Contributor Author

nilason commented Nov 6, 2024

Extracting the tarball

Just for clarification: where (in the CI?) is the tarball created? Because the release tarballs contain the version in the directory name.

The tarball is created in CI and added to the Assets section of a release (e.g. https://github.com/OSGeo/grass/releases/tag/8.4.0). That tarball is/was named correctly, e.g. grass-8.4.0.tar.gz, but the same tarball extracted a containing directory named only grass (because of the git repo name is "grass"). With this change the container directory will be named grass-8.4.0.

This/these tarballs may (or rather should, as include/VERSION_GIT file is generated into it) be uploaded to the osgeo download server manually (in the future possibly automatically).

See discussion in GRASS-dev ML.

@neteler
Copy link
Member

neteler commented Nov 6, 2024

See discussion in GRASS-dev ML.

Oh, I had completely forgotten about this one... and it would affect the upcoming GRASS GIS 8.4.1.

@nilason
Copy link
Contributor Author

nilason commented Nov 6, 2024

See discussion in GRASS-dev ML.

Oh, I had completely forgotten about this one... and it would affect the upcoming GRASS GIS 8.4.1.

I didn't :-), and yes, that's why I hurried up with this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport to 8.4 PR needs to be backported to release branch 8.4 CI Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants