Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Restrict default permissions on GitHub Actions workflows #4942

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

echoix
Copy link
Member

@echoix echoix commented Jan 11, 2025

This PR makes some fixes to the new security issues found by CodeQL for the actions (GitHub Actions) language, added in #4940.

I searched for the needed permissions as much as I could find, and I tested this PR as much as I could, even using my default branch. Why I say as much as I could? Well, my fork is a fork, and it is not in an organization, and I do not know exactly the remaining settings that are applied, but I still changed my actions settings (https://github.com/OSGeo/grass/settings/actions) to "Read repository contents and packages permissions", which is the new default for new repos after some date in 2023.
image

I suggest changing our settings to that, if possible (cc @neteler or @wenzeslaus). For organizations, it might be different, and I hope it isn't only possible at the org-level.

@github-actions github-actions bot added the CI Continuous integration label Jan 11, 2025
@echoix echoix force-pushed the codeql-actions-fixes branch from 94c7fe0 to e262c66 Compare January 14, 2025 16:19
@echoix echoix requested a review from nilason January 14, 2025 22:29
@echoix echoix merged commit a01bbfa into OSGeo:main Jan 14, 2025
28 checks passed
@echoix echoix deleted the codeql-actions-fixes branch January 14, 2025 22:46
@github-actions github-actions bot added this to the 8.5.0 milestone Jan 15, 2025
@neteler
Copy link
Member

neteler commented Jan 15, 2025

I suggest changing our settings to that, if possible (cc @neteler or @wenzeslaus). For organizations, it might be different, and I hope it isn't only possible at the org-level.

Is there any action item left?

@echoix
Copy link
Member Author

echoix commented Jan 15, 2025

I suggest changing our settings to that, if possible (cc @neteler or @wenzeslaus). For organizations, it might be different, and I hope it isn't only possible at the org-level.

Is there any action item left?

Nope, in the security tab, sorted by newest, there isn't anything left in the open issues that concern GitHub actions https://github.com/OSGeo/grass/security/code-scanning?query=is%3Aopen+branch%3Amain+sort%3Acreated-desc

@echoix
Copy link
Member Author

echoix commented Jan 15, 2025

Oh, I misread, I cannot know what settings you have. You can send me a picture by email of the settings from the link in the PRs description if you'd like me to check

nilason pushed a commit to nilason/grass that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants