Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: use of imported Freetype target #5313

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nilason
Copy link
Contributor

@nilason nilason commented Mar 6, 2025

Use imported Freetype target.

@nilason nilason added this to the 8.5.0 milestone Mar 6, 2025
@github-actions github-actions bot added vector Related to vector data processing libraries module general CMake labels Mar 6, 2025
@echoix
Copy link
Member

echoix commented Mar 6, 2025

I have a question. What happens if we select WITH_FREETYPE=off, does g.mkfontcap and v.label.sa compile as expected? Here there's no usage of PRIMARY_DEPENDS like in the other PRs. Is this because the headers are conditionally included (include guard), and cmake imported targets don't fail when they don't exist?

@nilason
Copy link
Contributor Author

nilason commented Mar 6, 2025

I have a question. What happens if we select WITH_FREETYPE=off, does g.mkfontcap and v.label.sa compile as expected? Here there's no usage of PRIMARY_DEPENDS like in the other PRs. Is this because the headers are conditionally included (include guard), and cmake imported targets don't fail when they don't exist?

Thanks, good point! It is my understanding that none of the two would work without Freetype, added PRIMARY_DEPENDS.

@echoix
Copy link
Member

echoix commented Mar 6, 2025

Thanks, good point! It is my understanding that none of the two would work without Freetype, added PRIMARY_DEPENDS.

I didn't dive into the source, do they work without? Does configuring work without too?

@nilason
Copy link
Contributor Author

nilason commented Mar 6, 2025

Thanks, good point! It is my understanding that none of the two would work without Freetype, added PRIMARY_DEPENDS.

I didn't dive into the source, do they work without? Does configuring work without too?

As far as I can tell, they do not work without. As "ordinary" DEPENDSs they would silently not build, whereas with PRIMARY_DEPENDS there is a message in configure, which can be good to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake general libraries module vector Related to vector data processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants