New comments functionality #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArielBatkilin
requested review from
jherskow,
matanel-oren,
Nitay880 and
nvgoldin
as code owners
Nitay880
approved these changes
Jul 7, 2020
nvgoldin
requested changes
Jul 7, 2020
| import axios from "axios"; | ||
|
|
||
|
|
||
| import authHeader from '../../services/auth-header'; |
There was a problem hiding this comment.
Can you move this to the story-service instead and extend it with the needed calls?
| } | ||
|
|
||
| handleSubmit(event) { | ||
| axios.post(API_URL + '/story/comment', { |
There was a problem hiding this comment.
Same here -> move to the service
| } | ||
|
|
||
| get_comments() { | ||
| return axios.get(API_URL + '/story/comment', { |
| path = path.replace("thumb/", ""); | ||
| return path | ||
| function get_comments(){ | ||
| return ["thats amazing!","unbelivable!"] |
There was a problem hiding this comment.
? should probably be removed
matanel-oren
requested changes
Jul 8, 2020
There was a problem hiding this comment.
CardComponent properties and design should be shared by our 2 layers, the only difference between those two is the author property. Therefore, it will be sensible to get all its properties (title, content, image path, and comments) in its constructor, and afterwards to use them when rendering.
matanel-oren
requested changes
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some comments in frontend