Fix Sysmon KQL parser output column casing #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for the word GUID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Event id 10 has a different casing for the word
GUIDcompared to the other events. The columns are cased asSourceProcessGUIDandTargetProcessGUIDin Event id 10 while all other events useSourceProcessGuid,TargetProcessGuidandProcessGuid.This results in output where columns cased in both ways exist, but only 1 contains the correct value, while the other one is empty.
This makes it annoying to compare or join event types. It might also accidently introduce false negatives because both columns exists but are empty in some cases since the differently cased column should have been used.
This is a breaking change !