Tghosth-patch-1

[sandrogauci]

This Pull Request relates to issue #1612

[tghosth]

Hi @elarlang, can you confirm if the updates here resolve all the points you raised?

[elarlang]

Nice work, I approved the PR, also I give some more feedback.

53.2.4

... from causing DoS or audio or video media insertion on new or existing media streams.

• 4x or, quite complicated to follow.
• DoS - maybe to write it out as denial of service

I think 53.2.5, 53.2.6, and 53.2.7 need more work as there seem to be duplicate recommendations and those are quite long requirements.

53.2.5

This should be achieved by implementing rate limiting, validating timestamps, using synchronized clocks to match real-time intervals, and managing buffers to prevent overflow and maintain proper timing. If packets for a particular media session arrive too quickly, excess packets should be dropped.

53.2.6

... by implementing rate limiting, validating timestamps, using synchronized clocks to match real-time intervals, and managing buffers to prevent overflow and maintain proper timing. If packets for a particular media session arrive too quickly, excess packets should be dropped.

53.2.7

This should be achieved by implementing input validation, safely handling integer overflows, preventing buffer overflows, and employing other robust error-handling techniques.

[tghosth]

@sandrogauci I proposed a refactoring here:
https://github.com/sandrogauci/ASVS/pull/1/files

This should address Elar's concerns I think.

If you are comfortable with the changes, you can merge that PR which will include in this PR.

[sandrogauci]

@sandrogauci I proposed a refactoring here: https://github.com/sandrogauci/ASVS/pull/1/files

This should address Elar's concerns I think.

If you are comfortable with the changes, you can merge that PR which will include in this PR.

That is really helpful thanks! I asked for one minor change.