Clarify token terminology throughout to resolve #2414 #2434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elarlang
requested changes
Dec 5, 2024
There was a problem hiding this comment.
I feel we are looping with this one and PR is different than agreed in the related issue.
- I prefer V52 title to be "Self-contained tokens" as it was.
- V4.2.5 should use self-contained tokens
- "Self-Contained Token - A subset of cryptographically secured tokens" - I really don't like that. It's not a subset, self-contained tokens are using cryptography for integrity. Whatever uses crypto for integrity is not subset of it, those are just using it. I think those proposals were good: Terminology and glossary update for token clarity #2414 (comment)
|
Commented in the issue: #2414 (comment) |
elarlang
reviewed
Dec 6, 2024
elarlang
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request relates to issue #2414
@ryarmst @elarlang @randomstuff @TobiasAhnoff