Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use comma after e.g. and i.e. #2524

Merged
merged 3 commits into from
Jan 13, 2025
Merged

Use comma after e.g. and i.e. #2524

merged 3 commits into from
Jan 13, 2025

Conversation

randomstuff
Copy link
Contributor

No description provided.

jmanico
jmanico approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@jmanico jmanico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar Police Excellence :)

@elarlang elarlang marked this pull request as draft January 13, 2025 06:00
@elarlang
Copy link
Collaborator

Converted to draft because:

  • Asvs 2515 tag change #2522 changes many requirements and needs to get merged first
  • If comma change in this PR happens to yet not modified requirement, it must have the label GRAMMAR

@elarlang elarlang marked this pull request as ready for review January 13, 2025 08:09
@elarlang elarlang merged commit b418c64 into OWASP:master Jan 13, 2025
6 checks passed
@randomstuff randomstuff deleted the eg-ie-comma branch January 21, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmanico jmanico jmanico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@randomstuff @elarlang @jmanico