Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Logic and Migrate SortBy Component from ShadCN to Chakra UI #608

Merged
merged 12 commits into from
Jan 26, 2025

Conversation

Rajgupta36
Copy link
Collaborator

Resolves #73

Tasks

  • Migrate sortBy component from Shadcn to Chakra UI
  • Separate buttons for order and attribute sorting
  • Update Jest setup to support Chakra UI test cases

Media

updatedcss.mp4

@arkid15r arkid15r requested a review from aramattamara January 25, 2025 19:54
Copy link
Collaborator

@kasya kasya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this! A couple of suggestions and one issue that I found:

frontend/src/components/SortBy.tsx Outdated Show resolved Hide resolved
frontend/src/components/SortBy.tsx Show resolved Hide resolved
@Rajgupta36 Rajgupta36 requested a review from kasya January 26, 2025 20:11
Copy link
Collaborator

@kasya kasya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@kasya kasya added this pull request to the merge queue Jan 26, 2025
github-merge-queue bot pushed a commit that referenced this pull request Jan 26, 2025
)

* fix

* updated_logic

* UI_update

* fix bugs

* rm-shadcn dropdown component

* fixed_css

* fix_css

* added checkicon

* Fix padding in sort menu

---------

Co-authored-by: Kate Golovanova <[email protected]>
Merged via the queue into OWASP:main with commit 60ad19b Jan 26, 2025
13 checks passed
@Rajgupta36 Rajgupta36 deleted the update_sortBy_component branch January 27, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Implement Project page sorting
2 participants