-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented skeleton from chakra ui #611
Conversation
The skeleton has been created only for the following routes:
|
The previous (closed) PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hi @Dishant1804 , @harsh3dev , @Rajgupta36 , @kasya and @arkid15r , I need your advice regarding the Chapter Details and Project Details pages. Do you think we should make them more generic, or would it be better to keep them as they are and just rely on a loader for the details pages? Looking forward to hearing your thoughts! |
Looks Good and well implemented |
Hi @abhayymishraa, I think we have many modules on the details page. If you want to avoid implementing too many conditions, using a loading spinner could be a good option. Alternatively, you could create skeletons for the details page modules—maybe static ones (which are good but not reusable) or for all tiny components that used in details page to make them reusable. It’s totally up to you. |
I think for now loader is good as the details page has many components, later on we can apply lazy loading with skeleton If needed, lets see what others have to say. |
This seems a better approach to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me! A couple code related comments:
One more thing that came to my mind is in the code there are flex and box tags which just kills the purpose of using tailwind css, those components of chakraUI use emotion css, not sure of whether we should use that or use normal div tags and go with tailwind css. |
@Dishant1804, I noticed that you previously mentioned using Chakra components for this. Could you clarify why we’re considering a different approach now? Just trying to understand the reasoning behind this change. |
@abhayymishraa There is no change as such just want to know from others that are we going to completely migrate to it or we are going to use some of the components as mentioned while i raised the whole issue of migrating to chakraUI, i didn't clarify that we are completely migrating to chakraUI, And i want to understand that are we going to use Flex and Box as i need to make the changes accordingly to the card component in that case. |
Alright, let’s wait to hear from others before moving forward. |
It seems like a topic for a discussion (as well as tailwindcss vs emotion css). As for this PR I'm going to merge it if everybody is okay with that. |
@arkid15r Sure we can proceed with this as of now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for going an extra mile to implement it more efficiently 👍
Resolves #420
Add the PR description here.
Screencast.from.26-01-25.03.16.43.AM.IST.webm