Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented skeleton from chakra ui #611

Merged
merged 9 commits into from
Jan 28, 2025
Merged

Conversation

abhayymishraa
Copy link
Collaborator

@abhayymishraa abhayymishraa commented Jan 25, 2025

Resolves #420

Add the PR description here.

  • Implemented Skeleton from chakra ui
  • Made it generic
Screencast.from.26-01-25.03.16.43.AM.IST.webm

@abhayymishraa
Copy link
Collaborator Author

The skeleton has been created only for the following routes:

  • /chapters
  • /projects
  • /community/user
  • /projects/contribute
  • /committees
  • /committees/:chapter
    @arkid15r what's the next step?

@arkid15r
Copy link
Collaborator

The previous (closed) PR

Copy link
Collaborator

@Dishant1804 Dishant1804 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@abhayymishraa
Copy link
Collaborator Author

Hi @Dishant1804 , @harsh3dev , @Rajgupta36 , @kasya and @arkid15r ,

I need your advice regarding the Chapter Details and Project Details pages. Do you think we should make them more generic, or would it be better to keep them as they are and just rely on a loader for the details pages?

Looking forward to hearing your thoughts!

@yashgoyal0110
Copy link
Contributor

Looks Good and well implemented

@Rajgupta36
Copy link
Collaborator

Hi @Dishant1804 , @harsh3dev , @Rajgupta36 , @kasya and @arkid15r ,

I need your advice regarding the Chapter Details and Project Details pages. Do you think we should make them more generic, or would it be better to keep them as they are and just rely on a loader for the details pages?

Looking forward to hearing your thoughts!

Hi @abhayymishraa, I think we have many modules on the details page. If you want to avoid implementing too many conditions, using a loading spinner could be a good option. Alternatively, you could create skeletons for the details page modules—maybe static ones (which are good but not reusable) or for all tiny components that used in details page to make them reusable. It’s totally up to you.
@arkid15r and @kasya, what are your thoughts on this?

@harsh3dev
Copy link
Collaborator

Hi @Dishant1804 , @harsh3dev , @Rajgupta36 , @kasya and @arkid15r ,

I need your advice regarding the Chapter Details and Project Details pages. Do you think we should make them more generic, or would it be better to keep them as they are and just rely on a loader for the details pages?

Looking forward to hearing your thoughts!

I think for now loader is good as the details page has many components, later on we can apply lazy loading with skeleton If needed, lets see what others have to say.

@Dishant1804
Copy link
Collaborator

Hi @Dishant1804 , @harsh3dev , @Rajgupta36 , @kasya and @arkid15r ,
I need your advice regarding the Chapter Details and Project Details pages. Do you think we should make them more generic, or would it be better to keep them as they are and just rely on a loader for the details pages?
Looking forward to hearing your thoughts!

I think for now loader is good as the details page has many components, later on we can apply lazy loading with skeleton If needed, lets see what others have to say.

This seems a better approach to me

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! A couple code related comments:

frontend/src/components/ui/skeleton.tsx Outdated Show resolved Hide resolved
frontend/src/components/skeletons/Card.tsx Outdated Show resolved Hide resolved
@Dishant1804
Copy link
Collaborator

Dishant1804 commented Jan 27, 2025

One more thing that came to my mind is in the code there are flex and box tags which just kills the purpose of using tailwind css, those components of chakraUI use emotion css, not sure of whether we should use that or use normal div tags and go with tailwind css.
Your inputs will be valuable here @harsh3dev @yashgoyal0110 @Rajgupta36 @arkid15r @kasya

@abhayymishraa
Copy link
Collaborator Author

@Dishant1804, I noticed that you previously mentioned using Chakra components for this. Could you clarify why we’re considering a different approach now? Just trying to understand the reasoning behind this change.

@Dishant1804
Copy link
Collaborator

Dishant1804 commented Jan 27, 2025

@Dishant1804, I noticed that you previously mentioned using Chakra components for this. Could you clarify why we’re considering a different approach now? Just trying to understand the reasoning behind this change.

@abhayymishraa There is no change as such just want to know from others that are we going to completely migrate to it or we are going to use some of the components as mentioned while i raised the whole issue of migrating to chakraUI, i didn't clarify that we are completely migrating to chakraUI, And i want to understand that are we going to use Flex and Box as i need to make the changes accordingly to the card component in that case.
As i said i am still not sure whether we are going to use Flex and Box tags, that is why i asked the inputs/opinions from others

@abhayymishraa
Copy link
Collaborator Author

Alright, let’s wait to hear from others before moving forward.

@arkid15r
Copy link
Collaborator

@Dishant1804, I noticed that you previously mentioned using Chakra components for this. Could you clarify why we’re considering a different approach now? Just trying to understand the reasoning behind this change.

@abhayymishraa There is no change as such just want to know from others that are we going to completely migrate to it or we are going to use some of the components as mentioned while i raised the whole issue of migrating to chakraUI, i didn't clarify that we are completely migrating to chakraUI, And i want to understand that are we going to use Flex and Box as i need to make the changes accordingly to the card component in that case. As i said i am still not sure whether we are going to use Flex and Box tags, that is why i asked the inputs/opinions from others

It seems like a topic for a discussion (as well as tailwindcss vs emotion css).

As for this PR I'm going to merge it if everybody is okay with that.

@Dishant1804
Copy link
Collaborator

@Dishant1804, I noticed that you previously mentioned using Chakra components for this. Could you clarify why we’re considering a different approach now? Just trying to understand the reasoning behind this change.

@abhayymishraa There is no change as such just want to know from others that are we going to completely migrate to it or we are going to use some of the components as mentioned while i raised the whole issue of migrating to chakraUI, i didn't clarify that we are completely migrating to chakraUI, And i want to understand that are we going to use Flex and Box as i need to make the changes accordingly to the card component in that case. As i said i am still not sure whether we are going to use Flex and Box tags, that is why i asked the inputs/opinions from others

It seems like a topic for a discussion (as well as tailwindcss vs emotion css).

As for this PR I'm going to merge it if everybody is okay with that.

@arkid15r Sure we can proceed with this as of now

@arkid15r arkid15r enabled auto-merge January 28, 2025 19:48
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for going an extra mile to implement it more efficiently 👍

@arkid15r arkid15r added this pull request to the merge queue Jan 28, 2025
Merged via the queue into OWASP:main with commit 10127da Jan 28, 2025
13 checks passed
@abhayymishraa abhayymishraa deleted the feat/skelton branch January 28, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Current Loader with the Skeleton Component
7 participants