Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a toast for graphql error handling #612

Merged
merged 7 commits into from
Jan 28, 2025

Conversation

abhayymishraa
Copy link
Collaborator

Resolves #524

Add the PR description here.

  • Added a toast error message to display when the query fails.
  • Ensured the toast renders only after the isLoading state (loader) is false to prevent it from appearing during the loading screen, as that would not look ideal.
  • I didn't use chakra ui as if we chakra ui toast it will interfere with the shadcn toast and someone is already created a issue for that

Preview

Screencast.from.26-01-25.05.23.57.PM.IST.webm

Copy link
Collaborator

@aramattamara aramattamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Left one suggestion to improve.

frontend/src/pages/ProjectDetails.tsx Outdated Show resolved Hide resolved
@aramattamara
Copy link
Collaborator

This can be merged if @kasya and @arkid15r don't have any further suggestions.

@arkid15r arkid15r enabled auto-merge January 28, 2025 21:27
@arkid15r
Copy link
Collaborator

@aramattamara could you approve it too?

Screenshot 2025-01-28 at 1 27 55 PM

Copy link
Collaborator

@aramattamara aramattamara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arkid15r arkid15r added this pull request to the merge queue Jan 28, 2025
@abhayymishraa
Copy link
Collaborator Author

Thank You!!!

Merged via the queue into OWASP:main with commit f00f251 Jan 28, 2025
13 checks passed
@abhayymishraa abhayymishraa deleted the fix/graphQlError branch February 3, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement GraphQL PoC
4 participants