Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Issue and Releases Field #625

Merged
merged 24 commits into from
Feb 12, 2025
Merged

Added Issue and Releases Field #625

merged 24 commits into from
Feb 12, 2025

Conversation

Yashgupta9330
Copy link
Collaborator

fixes #387

@Yashgupta9330 Yashgupta9330 marked this pull request as draft January 27, 2025 12:16
@Yashgupta9330 Yashgupta9330 marked this pull request as ready for review January 27, 2025 15:25
arkid15r
arkid15r requested changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run pre-commit. Always run pre-commit.

Also this is how it looks in the dark theme:

Screenshot 2025-01-27 at 9 05 50 AM

@Yashgupta9330
Copy link
Collaborator Author

Yashgupta9330 commented Jan 27, 2025 •
edited
Loading

i ran pre-commit command then also getting same error but i added the dark theme support

@arkid15r
Copy link
Collaborator

i ran pre-commit command then also getting same error but i added the dark theme support

make check and make test must be green locally in order to pass CI/CD.

arkid15r
arkid15r reviewed Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the code and fixed some tests. Please see the comment below:

frontend/src/utils/paramsMapping.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot added the schema label Feb 3, 2025
@github-actions github-actions bot removed the schema label Feb 4, 2025
@arkid15r arkid15r enabled auto-merge February 12, 2025 01:49
arkid15r
arkid15r approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this!

@arkid15r arkid15r added this pull request to the merge queue Feb 12, 2025
Merged via the queue into OWASP:main with commit 5ead2a2 Feb 12, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkid15r arkid15r arkid15r approved these changes

@kasya kasya Awaiting requested review from kasya kasya is a code owner

Assignees
No one assigned
Labels
backend backend-tests frontend frontend-tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend user details page w/ issue/release data
3 participants
@Yashgupta9330 @arkid15r @kasya