Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nestbot news command #643

Merged
merged 11 commits into from
Feb 1, 2025
Merged

nestbot news command #643

merged 11 commits into from
Feb 1, 2025

Conversation

yashgoyal0110
Copy link
Contributor

fixes: #642

news.mp4

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works but the idea is to get the contents dynamically w/o the need to update the output manually

@yashgoyal0110
Copy link
Contributor Author

This works but the idea is to get the contents dynamically w/o the need to update the output manually

You mean fetching news data through some api?

@arkid15r
Copy link
Collaborator

This works but the idea is to get the contents dynamically w/o the need to update the output manually

You mean fetching news data through some api?

We have an example of getting file contents from GitHub here. In this case we need to get contents from multiple files (latest 10 for example).

@arkid15r arkid15r marked this pull request as draft January 28, 2025 19:37
@yashgoyal0110
Copy link
Contributor Author

yashgoyal0110 commented Jan 29, 2025

This works but the idea is to get the contents dynamically w/o the need to update the output manually

You mean fetching news data through some api?

We have an example of getting file contents from GitHub here. In this case we need to get contents from multiple files (latest 10 for example).

we are not targeting redirection link on every news......ryt?

@arkid15r
Copy link
Collaborator

This works but the idea is to get the contents dynamically w/o the need to update the output manually

You mean fetching news data through some api?

We have an example of getting file contents from GitHub here. In this case we need to get contents from multiple files (latest 10 for example).

we are not targeting redirection link on every news......ryt?

Up to you, sounds like it works too.

@yashgoyal0110
Copy link
Contributor Author

This works but the idea is to get the contents dynamically w/o the need to update the output manually

You mean fetching news data through some api?

We have an example of getting file contents from GitHub here. In this case we need to get contents from multiple files (latest 10 for example).

we are not targeting redirection link on every news......ryt?

Up to you, sounds like it works too.

Screen.Recording.2025-01-31.at.12.34.24.AM.mp4

@yashgoyal0110 yashgoyal0110 marked this pull request as ready for review January 30, 2025 19:21
backend/pyproject.toml Outdated Show resolved Hide resolved
backend/apps/slack/commands/news.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this!

@arkid15r arkid15r enabled auto-merge February 1, 2025 18:45
@arkid15r arkid15r added this pull request to the merge queue Feb 1, 2025
@yashgoyal0110
Copy link
Contributor Author

Thanks for addressing this!

👍✅

Merged via the queue into OWASP:main with commit 3512c99 Feb 1, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve NestBot /news command
2 participants